CSS fix for hamburger menu positioning bug on iOS 15.1 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Exactly for the sake of animations This is kinda low priority for us right now because we don't currently have a physical iOS 15.1 at the office. I'll test these things out anyway soon enough but feel free to do your own research if you have time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#134
Pushing this just to show the changes, I don't think this is a proper fix though. I am just realizing that doing this breaks the animation/transition effect of the menu panel when opening. It does fix the actual origin issue though. I can likely take another look tomorrow and see what alternatives there may be.